-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add statement cache and test case #73
base: master
Are you sure you want to change the base?
add statement cache and test case #73
Conversation
我今天生病发烧了,只能明天帮你看了,头晕。 |
好的,casa注意身体。 |
这个PR我会保持Open,你可以继续提交更新,使得能够通过完整测试 |
好的,我去看下哪里出问题了。 |
还没改完,昨天先提交了一次😂 |
👌我以为你已经改完了,那你只管提交没问题的,改完了跟我说一声就行~ |
好的,谢谢casa; |
当sqlString中有汉字时,sqlString.length != [sqlString UTF8String]的字节长度(汉字UTF8编码中占两个字节)。 所以这里应该是(int)[sqlString lengthOfBytesUsingEncoding:NSUTF8StringEncoding],或像前一个版本一样写成-1
sql语句中有汉字时result=SQLITE_ERROR
casa,我提交了现在可以通过测试了;但是现在运行demo的async test, 有时候没执行完就finish了, 麻烦casa看下。 |
你现在的分支有冲突,需要rebase一下 |
…jiang/CTPersistance into feature-statement-cache
casa冲突解决了。 |
很棒!test case全部通过了!跑async test的时候,控制台报了错误: ====================== <NSThread: 0x6000028b6a00>{number = 1, name = main} /Users/casa/Playground/CTPersistance/CTPersistance/CTPersistance/QueryCommand/Statement/CTPersistanceSqlStatement.m
====================== 你可以看一下 |
好的。 |
casa, 跑完test case 运行async test 的时候应该是TestTable 执行queryCommand的时候,在
secretKey 为nil, 所以没有执行到 还请casa 确认下。 |
写了个statement的cache, 希望casa看下哪里还有问题。