Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisibilityXds (and SpectrumXds): scan_number (int) => scan_name (str) #348

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

FedeMPouzols
Copy link
Collaborator

@FedeMPouzols FedeMPouzols commented Jan 16, 2025

Resolves #333.


Note well:

This contribution is made under the current ALMA software agreements. 
(c) European Southern Observatory, 2024, 2025
Copyright by ESO (in the framework of the ALMA collaboration)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@FedeMPouzols
Copy link
Collaborator Author

FedeMPouzols commented Jan 16, 2025

Note that this will fail the tests with "preconverted" vis.zarr datasets. I cannot upload to the dropbox folder, but I prepared this zip:
Antennae_North.cal.lsrk.split.ms.zip
This also needs to be changed for the S3 test I think (that one seems to have a "v5" which I'm not sure if implies some difference).

@Jan-Willem
Copy link
Member

@FedeMPouzols I also have some changes that will require a new Antennae_North.cal.lsrk.split. I will merge this branch into mine and generate the new Antennae_North.cal.lsrk.split.

@Jan-Willem Jan-Willem merged commit 701d2ca into main Feb 5, 2025
3 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VisibilityXds: scan_number
3 participants