Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in get_ps_freq_axis(), with outdate frame key #300

Merged

Conversation

FedeMPouzols
Copy link
Collaborator

@FedeMPouzols FedeMPouzols commented Oct 30, 2024

Fixes #299


Note well:

This contribution is made under the current ALMA software agreements. 
(c) European Southern Observatory, 2024 
Copyright by ESO (in the framework of the ALMA collaboration)

@FedeMPouzols FedeMPouzols linked an issue Oct 30, 2024 that may be closed by this pull request
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@FedeMPouzols
Copy link
Collaborator Author

From the errors in the Mac builds, I see that this recent change in the schema is not yet in the "preconverted" and "S3" datasets, which I had missed. For now I've changed some of the checks that I added in this PR to be done only if not preconverted/s3.

@Jan-Willem Jan-Willem merged commit 5b8a94e into main Oct 31, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with outdated frame key in get_ps_freq_axis()
3 participants