Lofar performance improvements #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The else clause is never reached, it is handled in line 2
Ensure chunk encoding isn't specified when the DataArray is a dask array
Create TableManager class so casacore tables are opened on each thread/process as needed, avoids serialization issues
Adds read_col_conversion_dask which creates a lazy representation of DataArray. Each lazy chunk contains a column read and a reshaping step. The input argument lofar_read_size is used to control both the size of contiguous reads from the measurement set and the size of chunks on the zarr store
sstansill
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new method
read_col_conversion_daskthat allows larger than memory columns to be converted. Various changes:lofarandlofar_read_sizearguments added toconvert_msv2_to_processing_setopen_table_roandopen_queryinconvert_and_write_partitionread_col_conversion_daskuses dask's map_blocks to create tasks for each chunk of a DataArray which reads data from a MSv2 column and reshapes itThis has been used to convert 9TB of lofar data in ~4.5 hours which was previously impossible unless a compute node with >9TB of memory is used