WeatherXds: time_weather

[kettenis]

Description talks about time_cal instead of time_weather.

Also in PhaseCalibrationXds we have time_phase_cal. Maybe it would make sense to call all of these time_cal?

[Jan-Willem]

WeatherXds has been updated to refer to time_weather only.

Convention time/time_* is used to indicate whether the time axis has been interpolated to the correlated_xds's time axis. Since these are separate datasets we choose to use distinct names for each.

[FedeMPouzols]

Oh yes, sorry the wrong time_cal in WeatherXds was an error in the schema that is now fixed, but I forgot to link the PR to this issue.

Given that the xds specific time_* of PhaseCalibrationXds is time_phase_cal, perhaps we could use time_system_cal for SystemCalibrationXds (rather than the generic time_cal which could be confused as referring to other cals)?

A similar consideration would apply to frequency_cal, although that one is only used in once sub-xds: SystemCalibrationXds. Use frequency_system_cal to be fully explicit?

[FedeMPouzols]

The main issue reported here (time_cal=>time_weather in WeatherXds) was fixed already in #345.

What I'd proposed based on the comments above is, to make coordinate names more explicit and specific to every xds:

• time_cal => time_system_cal in SystemCalibrationXds
• frequency_cal => frequency_system_cal, also in SystemCalibrationXds.

Please let me know if this sounds fine. Otherwise there is not much more to do in this issue as far as I can see.

[Jan-Willem]

@FedeMPouzols, I agree that we should make the names more explicit.