Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRADIO Check Schema Implementation #247

Closed
12 tasks done
Jan-Willem opened this issue Sep 5, 2024 · 1 comment · Fixed by #255
Closed
12 tasks done

XRADIO Check Schema Implementation #247

Jan-Willem opened this issue Sep 5, 2024 · 1 comment · Fixed by #255
Assignees
Labels
enhancement New feature or request

Comments

@Jan-Willem
Copy link
Member

Jan-Willem commented Sep 5, 2024

Ensure that the schema in the spreadsheet (MSv4) matches the XRADIO implementation and the schema checker.

MSv4 Schema: https://docs.google.com/spreadsheets/d/1KIaYp6Qru1appToleyVqRdOEy9hmPhirpg0yR3ovAx0/edit?usp=sharing

  • main_xds (int and sd) (conversion+schema seem now in sync with spreadsheet as of 2024/09/12)
  • observation_info (added to conversion, mandatory in schema checker) - conversion+schema synced with spreadsheet as of 2024/09/12
  • partition_info - conversion+schema synced with spreadsheet as of 2024/09/12
  • processor_info (added to conversion, mandatory in schema checker) - conversion+schema synced with spreadsheet as of 2024/09/12
  • field_and_source_xds (conversion+schema seem now in sync with spreadsheet as of 2024/09/12)
    Antenna based:
  • antenna_xds (seems synced, some comment in spreadsheet - 2024/09/13)
  • pointing_xds (conversion+schema seem now in sync with spreadsheet as of 2024/09/13)
  • gain_curve_xds (seems synced, some comment in spreadsheet - 2024/09/13)
  • phase_cal_xds (seems synced, some comment in spreadsheet - 2024/09/13)
  • system_calibration_xds (conversion+schema seem now in sync with spreadsheet as of 2024/09/13)
  • weather_xds (conversion+schema seem now in sync with spreadsheet as of 2024/09/13)
  • phased_array_xds (skip)
@Jan-Willem Jan-Willem added the enhancement New feature or request label Sep 5, 2024
@FedeMPouzols FedeMPouzols changed the title XRADIO Check Schema Implemenation XRADIO Check Schema Implementation Sep 11, 2024
FedeMPouzols added a commit that referenced this issue Sep 11, 2024
FedeMPouzols added a commit that referenced this issue Sep 12, 2024
FedeMPouzols added a commit that referenced this issue Sep 12, 2024
FedeMPouzols added a commit that referenced this issue Sep 12, 2024
FedeMPouzols added a commit that referenced this issue Sep 13, 2024
FedeMPouzols added a commit that referenced this issue Sep 13, 2024
@FedeMPouzols
Copy link
Collaborator

This branch has now an updated version that brings the schema classes and the conversion code up to date with the spreadsheet:

  • There were a few comments open throughout the day, mostly about coordinates in gain_curve_xds, phase_calibration_xds, antenna_xds. But I think most if not all are now clear
  • The type attribute in the datasets, which @scpmw introduced I think, and I've been keeping and extending to new sub-datasets, is not in the spreadsheet.

Other than that I do not see other differences at the moment. If a few last checks on the current branch go well, I'll open a PR. If some adjustments are needed, those should be pretty small, so the disruptive changes of names that need to be done can start sooner than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants