You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I think a commit flipped start and end in the Triangle.trend method. However, nothing was done to correct the inputs of either the Trend estimator not CapeCod which uses the underlying triangle method, so I believe these are producing inaccurate results. I also think we shouldn't change behavior of existing methods without a formal deprecation. Users will likely have a variety of existing code that relies on the prior approach and they need a lead time to react to this change. I think this needs to be reverted.
Describe the bug
I think a commit flipped start and end in the Triangle.trend method. However, nothing was done to correct the inputs of either the
Trend
estimator notCapeCod
which uses the underlying triangle method, so I believe these are producing inaccurate results. I also think we shouldn't change behavior of existing methods without a formal deprecation. Users will likely have a variety of existing code that relies on the prior approach and they need a lead time to react to this change. I think this needs to be reverted.Refer to commit efde4a6 for items to be reverted.
The text was updated successfully, but these errors were encountered: