don't modify input when converting to orderedmap #870
Conversation
| "github.com/vmware-tanzu/carvel-ytt/pkg/orderedmap" | ||
| ) | ||
|
|
||
| func TestFromUnorderedMaps(t *testing.T) { |
There was a problem hiding this comment.
Test fails without the changes to convert.go
|
|
||
| // some sources (e.g. toml library) yield specific type of slices. | ||
| // slices in Go are not covariant, so each flavor of slice must have its own case, here. | ||
| // process these exactly the same way we do for generic slices (prior case) | ||
| case []map[string]interface{}: | ||
| resultArray := make([]interface{}, len(typedObj)) | ||
| result := make([]interface{}, len(typedObj)) |
There was a problem hiding this comment.
Renamed this because all the other case blocks use result as the new variable name
| @@ -0,0 +1,23 @@ | |||
| package orderedmap_test | |||
|
|
|||
There was a problem hiding this comment.
nit: could you please add header.
@notoriaga I think commit should be rebased because we recently changes the module name to |
notoriaga
force-pushed
the
steve/orderedmap-fix
branch
from
1322d92 to
6b3bdc8
Compare
Signed-off-by: notoriaga <[email protected]>
Signed-off-by: notoriaga <[email protected]>
notoriaga
force-pushed
the
steve/orderedmap-fix
branch
from
6b3bdc8 to
1b92636
Compare
Ahh I see, thanks! |
Signed-off-by: notoriaga <[email protected]>
|
LGTM |
I'm integrating with ytt as a library and noticed that when I convert an object to an
orderedmap.Mapthe input object gets modified. I'm not sure if that's intended but right now it requires me to deepcopy the input before converting which is a little unfortunate.