Respect filemarks for Starlark files #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review in #carvel @ 2023-01-25. |
jtigger
force-pushed
the
fix-starlark-filemark
branch
from
736c5c2 to
38cb4f7
Compare
cppforlife
approved these changes
Jan 26, 2023
Fixes #786 Signed-off-by: John Ryan <[email protected]>
jtigger
force-pushed
the
fix-starlark-filemark
branch
from
38cb4f7 to
63f4092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and plumb UI's stderr to Starlark's Print() so that even output from Starlark runtime respects UI settings.
Fixes #786