Allow template tests to have trailing empty lines #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to author template tests, because editors tend to append a newline when saving files.
Previously,
ERR:
template test could not have trailing empty lines. I am using both Vim and IntelliJ. Both make it hard to remove the last line break in the file. I spend a minute to figure it out, and in Vim you can do:set noendofline binary
for a buffer and it trims trailing whitespace. But that's a bother.I think it is better testing UX this way. I held back from letting my IDE add a line break to existing
*.tpltest
.