Bug fix: have data.list("/") read from root of library #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Garrett Cheadle <[email protected]>
gcheadle-vmware
changed the title
pivotaljohn
approved these changes
May 3, 2022
pkg/cmd/template/cmd_test.go
Outdated
| @@ -210,6 +210,94 @@ data: #@ data.read("/funcs/data")`) | |||
| assert.Equal(t, expectedYAMLTplData, string(file.Bytes())) | |||
| } | |||
|
|
|||
| func TestDataListRelativeToRootInDataValuesAndSchema(t *testing.T) { | |||
There was a problem hiding this comment.
These tests give me a lot of confidence that our "absolute path" loading works in both schema and data values -flavored templates. 👍🏻 Thank you for investing in this.
As I look around at the test files in pkg/cmd/template ... their ranks are growing. cmd_test.go is almost a KLOC.
If you haven't already thought about this, I'm wondering if these tests would be more "at home" in one of these test files:
cmd_root_library_test.gocmd_data_values_test.go
| @@ -97,7 +98,7 @@ func (pp DataValuesSchemaPreProcessing) collectSchemaDocs(schemaFiles []*FileInL | |||
| } | |||
|
|
|||
| func (pp DataValuesSchemaPreProcessing) extractSchemaDocs(schemaFile *FileInLibrary) ([]*yamlmeta.Document, error) { | |||
| libraryCtx := LibraryExecutionContext{Current: schemaFile.Library, Root: NewRootLibrary(nil)} | |||
| libraryCtx := LibraryExecutionContext{Current: schemaFile.Library, Root: pp.rootLibrary} | |||
There was a problem hiding this comment.
How about how minimizing the differences between Data Values and Data Values Schema processing makes this sweetly obvious that making the exact same change in both flows is the right move? ⭐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.