Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go Module name to "github.com/vmware-tanzu/carvel-ytt" #606

Merged
merged 5 commits into from
Feb 17, 2022

Conversation

gcheadle-vmware
Copy link
Contributor

No description provided.

@gcheadle-vmware
Copy link
Contributor Author

directory examples/integrating-with-ytt/internal-templating/ imports ytt v0.38.0 with module: github.com/k14s/ytt v0.38.0. Since v0.40.0 will be the first release with the new module name, this dependency will not need to be updated.

Copy link
Contributor

@cari-lynn cari-lynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, it's my understanding that the previous import paths: github.com/k14s/ytt will continue working with version v0.39.0 or earlier, and then to update to v0.40.0 the import path will need to be changed to github.com/vmware-tanzu/carvel-ytt. So integrators shouldn't have any interruptions.

(not required as part of this PR) After we cut v0.40.0 with the new module, we should update the examples/integrating-with-ytt/internal-templating/ directory since it mentions that the module will be renamed.

Copy link
Contributor

@pivotaljohn pivotaljohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gcheadle-vmware gcheadle-vmware merged commit b50fd58 into develop Feb 17, 2022
@gcheadle-vmware gcheadle-vmware deleted the module-rename branch February 17, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants