fix: clean paths after reading config

[Zebradil]

This PR adds mandatory processing of directory and content paths with the filepath.Clean function. It allows to avoid problems with paths containing .. and .. This, in turn, fixes the lazy functionality. At the moment, paths foo and foo/ (or even foo//) are treated as different destinations and are re-downloaded.

Fixes #347
Fixes #348

[kumaritanushree]

@Zebradil added one comment in issue #348, can you please check that once?

[100mik]

Reducing paths to their most minimal form before processing them makes sense too me 🚀
This is something we could throw a test in for. Maybe a vendir with something like files/...

This looks otherwise good to me!

[joaopapereira]

Since we are change the configuration directly will this have any impact on the lazy feature?

[Zebradil]

I'm not sure I understand the question.

Paths are clean up right after reading the config, so after that any operation uses so to say "canonical" path, including the lock file and lazy functionality.

[joaopapereira]

But if the lock file already exists, the path might be different correct?

[joaopapereira]

But if the lock file already exists, the path might be different correct?

[Zebradil]

Yes, the current vendir behavior is to copy paths from the config to the lock file literally. With the cleanup logic, paths can differ between the config and the lock file. It is basically the same as changing vendor/ to vendor in the config and run sync. The lock file will be updated with the new path.

So, yes, if this is merged, the next sync with the new version of vendir will invalidate the "lazy cache" in some cases. But I don't think that can be an issue.

[Zebradil]

It seems that in the community meeting we agreed to proceed with this idea. I'll add some e2e tests tomorrow.

[Zebradil]

The test has landed, please, review.

NOTE: I intentionally did not add test cases with destructive or insecure paths (e.g. .., /root, vendor/..) because they would become obsolete after implementing a better path validation logic.

[joaopapereira]

LGTM

[kumaritanushree]

LGTM