Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go tidy from release step #732

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

joaopapereira
Copy link
Member

Bump goreleaser to the latest version

Bump goreleaser to the latest version

Signed-off-by: João Pereira <[email protected]>
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙏🏻
Since we are planning to replicate this for other tools, should we test this on a fork once? (Ignore if already done)

@joaopapereira joaopapereira force-pushed the remove-fmt-from-release-step branch from f951621 to dbba784 Compare April 14, 2023 15:42
@rohitagg2020
Copy link
Contributor

LGTM. Want to understand why we removed go tidy and go vendor from release process?

@joaopapereira
Copy link
Member Author

When we are releasing our tools we want to make sure nothing changes. That is why we are removing those 2 steps

@kumaritanushree
Copy link
Contributor

LGTM

@sethiyash sethiyash merged commit 0ffc5fc into develop May 4, 2023
sethiyash pushed a commit that referenced this pull request May 4, 2023
* Remove go tidy from release step

Bump goreleaser to the latest version

Signed-off-by: João Pereira <[email protected]>

* Specify the tag being used for a release

Signed-off-by: João Pereira <[email protected]>

---------

Signed-off-by: João Pereira <[email protected]>
sethiyash pushed a commit that referenced this pull request May 5, 2023
* Remove go tidy from release step

Bump goreleaser to the latest version

Signed-off-by: João Pereira <[email protected]>

* Specify the tag being used for a release

Signed-off-by: João Pereira <[email protected]>

---------

Signed-off-by: João Pereira <[email protected]>
sethiyash added a commit that referenced this pull request May 8, 2023
* Remove go tidy from release step

Bump goreleaser to the latest version



* Specify the tag being used for a release



---------

Signed-off-by: João Pereira <[email protected]>
Co-authored-by: João Pereira <[email protected]>
@kumaritanushree
Copy link
Contributor

/cherry-pick v0.53.x

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 0ffc5fc5827ceec525a8f37450de54fb54fe93bc into temp-cherry-pick-0bef34-v0.53.x

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Jun 16, 2023
kumaritanushree pushed a commit that referenced this pull request Jun 16, 2023
* Remove go tidy from release step

Bump goreleaser to the latest version

Signed-off-by: João Pereira <[email protected]>

* Specify the tag being used for a release

Signed-off-by: João Pereira <[email protected]>

---------

Signed-off-by: João Pereira <[email protected]>
kumaritanushree added a commit that referenced this pull request Jun 16, 2023
kumaritanushree pushed a commit that referenced this pull request Jun 19, 2023
* Remove go tidy from release step

Bump goreleaser to the latest version

Signed-off-by: João Pereira <[email protected]>

* Specify the tag being used for a release

Signed-off-by: João Pereira <[email protected]>

---------

Signed-off-by: João Pereira <[email protected]>
@praveenrewar praveenrewar deleted the remove-fmt-from-release-step branch March 28, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel triage This issue has not yet been reviewed for validity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants