Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flag --layers to enable/disable functionality of showing each layers of image #639

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

kumaritanushree
Copy link
Contributor

No description provided.

Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

@@ -81,7 +84,7 @@ func (d *DescribeOptions) Run() error {
ttyEnabledLogger := util.NewUILevelLogger(logLevel, util.NewLoggerNoTTY(d.ui))
if d.OutputType == "text" {
p := bundleTextPrinter{logger: ttyEnabledLogger}
p.Print(description)
p.Print(description, d.Layers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not providing this option for the yaml output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In yaml with empty object it will not show the layers in output only.

pkg/imgpkg/cmd/describe.go Outdated Show resolved Hide resolved
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcmadhankumar rcmadhankumar merged commit b9bb269 into develop Feb 27, 2024
7 checks passed
@praveenrewar praveenrewar deleted the add-layer-flag branch February 27, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants