Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logger that always write on describe command #599

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Use logger that always write on describe command #599

merged 1 commit into from
Nov 6, 2023

Conversation

joaopapereira
Copy link
Member

Fixes #596

@joaopapereira joaopapereira had a problem deploying to TanzuNet Registry Dev e2e October 24, 2023 20:54 — with GitHub Actions Failure
@joaopapereira joaopapereira had a problem deploying to TanzuNet Registry Dev e2e October 24, 2023 20:56 — with GitHub Actions Failure
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e October 24, 2023 21:03 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to GCR e2e October 24, 2023 21:03 — with GitHub Actions Inactive
praveenrewar
praveenrewar requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove the "--tty" from the describe tests (as part of testing)?

@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e November 1, 2023 21:22 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to GCR e2e November 1, 2023 21:22 — with GitHub Actions Inactive
@joaopapereira joaopapereira merged commit 2a82dee into develop Nov 6, 2023
7 checks passed
@joaopapereira joaopapereira deleted the issue-596 branch November 6, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

imgpkg should emit plain text to be used in pipelines by default
2 participants
@joaopapereira @praveenrewar