Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Role change for Approver #582

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

praveenrewar
Copy link
Member

Summary

This is a formal request for consideration of a role change in the Carvel project by a member of the community.

Each role is defined in our contribution model document. If you would like to request mutliple roles / multiple subprojects,
please open a new issue for each request.

GitHub Username

@praveenrewar

Role Requested

  • Reviewer
  • Approver
  • Lead

Applicable Subproject

General Requirements

Role Specific Requirements

Reviewer

  • I have reviewed / authored of at least 5 substantial* pull requests to the subproject(s).

Approver

  • I have reviewed / authored several substantial* pull requests to the codebase.
  • Demonstrated the ability to plan and execute a track of work.

Sponsors

List of contributions to the Carvel subprojects(s)

I have been an active contributor to kapp for the past 15 months and have served as a reviewer for around 3 months.
During this time I was responsible for developing, triaging, and giving support for kapp.

PRs reviewed / authored

I have authored a total of 42 PRs and reviewed 76 PRs. Some of the most relevant PRs are:

Issues responded to

I have proactively responding to issues on Github and Slack to better understand the problem user is facing and providing a solution to it. Some of the issues are

Projects I am involved with

The first project I was part of was about incorporating externally applied resources. I have been part of almost all the projects of kapp for the past 6-7 months.
Some examples are:

You can find me in our Slack channel helping our users with questions about kapp (and sometimes other tools).

Next Steps

  • Once your sponsors have responded with a +1 for your nomination, your request will be reviewed by the project leads. Any missing information will be requested.

*Substantial is subject to the lead's discretion (e.g. refactors, enhancements rather than grammar correction or trivial pull requests)

Add Praveen as approver for kapp
@100mik
Copy link
Contributor

100mik commented Oct 28, 2022

+1
And thanks for everything you do!

@cppforlife
Copy link
Contributor

strongly in favor! thank you for @praveenrewar for all your efforts and contributions thus far, and looking forward where you take kapp further.

@rohitagg2020
Copy link
Contributor

+1
Truly deserving

@praveenrewar praveenrewar merged commit 6b3215f into develop Nov 2, 2022
@praveenrewar praveenrewar deleted the proposal-kapp-approver branch November 2, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants