Released 0.19.0 #172
Merged
Released 0.19.0 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release merge back
Due to the resulting in potential false passes
Remove runtime error lines
Added black and isort and fixed pytest dev branch
Changes the way that the config file is retrieved from pylint.config. Previously this was done using the static `variable pylint.config.PYLINTRC` which is defined at load by iterating over all the files found via `pylint.config.find_default_config_files()` until one ending in "pylintrc" is found. In pylint itself config seems instead to be found by calling `next(find_default_config_files(), None)` which is also able to find setup.cfg or pyproject.toml based config files automatically. I have thus changed PyLintPlugin to use the same version and can now call `py.test --pylint` and have config from my pyproject.toml picked up correctly. I have added one additional test, essentially copying the existing `test_pylint_file_toml`, but now called `test_pyline_file_pyproject_toml`, which is modified to name the config file `pyproject.toml` and does not pass the `--pyline-fcfile` option but expects it to be auto-detected. This test passes when the file is called pyproject.toml but fails when it is called something different.
…is being used and there is no support for pyproject.toml etc.
… file but still ran the test that would fail when it couldn't detect the file. this should fix that. I also had to modify the test invalidate_cache_when_config_changes as autofinding the config caused that test to fail (which I assume was not intended)
…lint - fixed that.
…figured, not at load time of the module which may have been affecting things. Also made a change to the import of pylint.config to comply with isort and pylint 2.3
…pport find_default_config_files
feat: auto-find config that is not pylintrc based
Fix typos
Python 3.5 reached its EOL in September 2020[1] and Python 3.6 reached its EOL in December 2021. [1]: https://peps.python.org/pep-0478/ [2]: https://peps.python.org/pep-0494/
pytest-flake8 doesn't work with flake8 v5. There's no need to run black, flake8, and isort with every combination of pylint and pytest.
- Consider using 'with' for resource-allocating operations (consider-using-with) - Using open without explicitly specifying an encoding (unspecified-encoding) - Formatting a regular string which could be a f-string (consider-using-f-string)
carsongee
force-pushed
the
rc/0.19.0
branch
from
d69f7df to
ae37a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release time! Thanks to all the amazing contributors 👏 👏 👏