Blender 4.0 and Command Line Rendering Fixes #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSenseStudio
commented
Nov 16, 2023
| @@ -18,6 +19,7 @@ class DreamTexturesRenderEngine(bpy.types.RenderEngine): | |||
| bl_label = "Dream Textures" | |||
| bl_use_preview = False | |||
| bl_use_postprocess = True | |||
| bl_use_gpu_context = actor.main_thread_rendering | |||
There was a problem hiding this comment.
For some reason bl_use_gpu_context = True allows for rendering annotations in background mode, but freezes under normal use. And bl_use_gpu_context = False works fine under normal use, but freezes while in background mode. So bl_use_gpu_context = actor.main_thread_rendering is the best that I'll get this to work.
|
Forgot to mention that I've made it cut down on some spam caused by the backend default not existing when you don't have any extra backend installed, and fixed a couple of issues for running on Blender 4.0 too. |
NullSenseStudio
changed the title
carson-katri
approved these changes
Dec 18, 2023
CyWP
added a commit
to CyWP/dream-forge
that referenced
this pull request
Feb 6, 2024
This reverts commit 26b842c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents deadlocks by checking when sections are running on the main thread to continue executing on the same thread rather than registering a timer and waiting on that. Forces requests to the subprocess to run in blocking mode while command line rendering is occurring, and since forcing blocking mode makes the returned Future complete before callbacks get added the done/exception callbacks will run immediately in that case.