Add default nodes when creating a new node tree using new_engine_node_tree #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the minimum required nodes and synchronize open editors
engine/engine.py
Outdated
| node_sd.location = (200, 200) | ||
| node_out = node_tree.nodes.new(type="NodeGroupOutput") | ||
| node_out.location = (400, 200) | ||
| node_tree.links.new(node_sd.outputs['Image'], node_out.inputs['']) |
There was a problem hiding this comment.
I think this connects the image to the virtual socket on the Group Output. You might need to add an image socket to it first, then link to that socket.
There was a problem hiding this comment.
It worked without but of course it should reflect what the user would get if they did it themselves so adding a color socket first is the cleaner solution for sure 👍🏻
carson-katri
requested changes
Dec 18, 2023
engine/engine.py
Outdated
| node_sd = node_tree.nodes.new(type="dream_textures.node_stable_diffusion") | ||
| node_sd.location = (200, 200) | ||
| node_out = node_tree.nodes.new(type="NodeGroupOutput") | ||
| node_tree.outputs.new('NodeSocketColor','Image') |
There was a problem hiding this comment.
Missed this before, outputs and inputs were removed in Blender 4. Could you add a check here for the bpy.app.version, and in Blender 4.0 use the .interface.new_socket(...) API?
There was a problem hiding this comment.
Added this to latest iteration but was not able to test yet.
carson-katri
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating new node trees, usually a functional minimal sample of a node tree is already created (Eevee, Cycles, Geometry Nodes, Compositor Nodes). This is not possible directly when the node tree type is defined via Python but Dream Textures has a secondardy operator new_engine_node_tree that is exposed in the render engine settings. Using this operator, we can simulate the default Blender behavior.
For the default nodes, I have selected Stable Diffusion and Output because they are the bare minimum render properties because that way the user will not run into the error of resolution mismatch between render engine and the stable diffusion output.