Fix Generating from Opened Blend File #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSenseStudio
commented
Nov 6, 2023
| @@ -64,7 +64,7 @@ def cancel(self): | |||
| def _run_on_main_thread(self, func): | |||
| try: | |||
| import bpy | |||
| bpy.app.timers.register(func) | |||
| bpy.app.timers.register(func, persistent=True) | |||
There was a problem hiding this comment.
Makes sure that model fetching completes when loading a file. Often when loading a file first it would fetch the models, then it gets queued in this timer, then the file actually loads and discards the timer. On rare occasions model fetching would complete along with the timer before the .blend file loads.
NullSenseStudio
commented
Nov 6, 2023
| @@ -123,7 +123,7 @@ class model_lookup: | |||
|
|
|||
| @classmethod | |||
| def get(cls, item): | |||
| return cls._models.get(item, item) | |||
| return cls._models.get(item, None) | |||
There was a problem hiding this comment.
We don't want to default to returning the model id string in case if the id is invalid or the models haven't loaded yet.
NullSenseStudio
commented
Nov 6, 2023
Comment on lines
-368
to
-369
| except Exception as e: | ||
| print(e) |
There was a problem hiding this comment.
These exceptions can be safely propagated since its at the end of the draw function, now it can properly show traceback info on errors it encounters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #729