Hide NodeResizeImage and NodeImageFile if not v3.5 #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phi-line
force-pushed
the
menu-hide-3.5-nodes
branch
2 times, most recently
from
4b5fceb to
885a09e
Compare
phi-line
commented
Apr 25, 2023
These nodes were not registered, but they were still present in the node categories. This commit follows the same hiding logic as in (un)registration.
phi-line
force-pushed
the
menu-hide-3.5-nodes
branch
from
885a09e to
5683955
Compare
|
@carson-katri I addressed your comments. This should be good to go |
|
On 3.5.1 I do not see several image related nodes, could that be related to this? |
carson-katri
pushed a commit
that referenced
this pull request
Jun 2, 2023
These nodes were not registered, but they were still present in the node categories. This commit follows the same hiding logic as in (un)registration.
carson-katri
added a commit
that referenced
this pull request
Jun 2, 2023
* Add custom metadata * Use default RENDER_PT_format panel * Add helper nodes * Improve nodes * Simplify join images node * Add is_used check * Improve node evaluation to support switch * Add Resize Image node * Ensure crop uses ints * Fix source image orientation * Add node for color correction * Hide NodeResizeImage and NodeImageFile if not v3.5 (#646) These nodes were not registered, but they were still present in the node categories. This commit follows the same hiding logic as in (un)registration. --------- Co-authored-by: phi-line <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files were not registered, but they were still present in the node categories. This commit follows the same hiding logic as in (un)registration.
This was my menu in 3.4, note the "Unknown" node
I since upgraded to 3.5, but I wanted to fix this for other 3.4 users!