-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prompt String To Material And Texture Names #499
Conversation
There are some conflicts now, could you resolve those? |
Oops, looks like my second PR got merged into this branch. I believe I've corrected it though and will make a second PR on another branch for the readme troubleshooting addition. |
I found that the naming in dream_textures.py was not working properly, cleaned up and fixed in c3ba80d. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a nice usability improvement, just a couple small suggestions.
Co-authored-by: Carson Katri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed an issue with long prompts. I had two ideas but maybe you have a better solution.
Co-authored-by: Carson Katri <[email protected]>
I found a weird discrepancy in project.py that causes the seed to be accessed differently than in dream_texture.py: dream_texture.py: project.py: Though I've named everything accordingly and tested them in 2c1623f That aught to do it, lmk what you think! ^_^ |
I think that's because |
Co-authored-by: Carson Katri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks!
Woohoo! Though I might mention that it seems even though blender appends the counter to duplicately named images it still will export/save them without the counter and can cause some overwrite issues. If we added our own three digit counter it would replace the Blender duplicate counter and alleviate the export issue but that might be more fringe of an fix/enhancement for later down the road. |
That seems like something Blender would need to change or provide some option for. |
No description provided.