Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prompt String To Material And Texture Names #499

Merged
merged 12 commits into from
Feb 3, 2023

Conversation

JasonHoku
Copy link
Contributor

No description provided.

@JasonHoku JasonHoku changed the title Merge branch 'main' of https://github.com/carson-katri/dream-textures Add Prompt String To Material And Texture Names Jan 3, 2023
@carson-katri
Copy link
Owner

There are some conflicts now, could you resolve those?

@JasonHoku
Copy link
Contributor Author

JasonHoku commented Jan 14, 2023

There are some conflicts now, could you resolve those?

Resolved and tested 👍

image

@JasonHoku
Copy link
Contributor Author

Oops, looks like my second PR got merged into this branch. I believe I've corrected it though and will make a second PR on another branch for the readme troubleshooting addition.

@carson-katri carson-katri added this to the v0.0.10 milestone Jan 15, 2023
@JasonHoku
Copy link
Contributor Author

I found that the naming in dream_textures.py was not working properly, cleaned up and fixed in c3ba80d.

@GottfriedHofmann GottfriedHofmann mentioned this pull request Jan 17, 2023
Copy link
Owner

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a nice usability improvement, just a couple small suggestions.

Copy link
Owner

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed an issue with long prompts. I had two ideas but maybe you have a better solution.

@JasonHoku
Copy link
Contributor Author

I found a weird discrepancy in project.py that causes the seed to be accessed differently than in dream_texture.py:

dream_texture.py: seed = result.seeds[i]

project.py: seed = generated[0].seeds[0]

Though I've named everything accordingly and tested them in 2c1623f

That aught to do it, lmk what you think! ^_^

@carson-katri
Copy link
Owner

I think that's because dream_texture has the iterations option to generate multiple images but project can only generate one.

@JasonHoku
Copy link
Contributor Author

JasonHoku commented Jan 28, 2023

btw I believe I noticed that Blender automatically appends a numerical counter to duplicately named images which adds four more characters to the name like .001 and so will trim out part of the seed in those cases.

So maybe we should change the 58 character count to 54 to remedy this.

image

@JasonHoku
Copy link
Contributor Author

That seems to do it!

image

Though I never noticed this error before, got a bad output on every other render (weird) and had to pull up the console to find this message:
The following part of your input was truncated because CLIP can only handle sequences up to 77 tokens: ['2 3 4 5 6 7 8 9']

Copy link
Owner

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@carson-katri carson-katri merged commit 76a363b into carson-katri:main Feb 3, 2023
@JasonHoku
Copy link
Contributor Author

Woohoo! Though I might mention that it seems even though blender appends the counter to duplicately named images it still will export/save them without the counter and can cause some overwrite issues.

If we added our own three digit counter it would replace the Blender duplicate counter and alleviate the export issue but that might be more fringe of an fix/enhancement for later down the road.

@carson-katri
Copy link
Owner

That seems like something Blender would need to change or provide some option for.

@carson-katri carson-katri mentioned this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants