Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Iterations and File Batch #485

Merged
merged 3 commits into from
Jan 8, 2023
Merged

Fix Iterations and File Batch #485

merged 3 commits into from
Jan 8, 2023

Conversation

NullSenseStudio
Copy link
Collaborator

Prevents the resulting images from being overwritten when using iterations or file batch. History entries are now only created once an image is finished to fix a crash that can be caused from creating and keeping references to multiple entries at a time, and will no longer leave extra duplicate entries if generation is stopped early. Also fixes a bug where generation would continue to the next iteration when attempting to cancel.

@NullSenseStudio NullSenseStudio linked an issue Dec 28, 2022 that may be closed by this pull request
@NullSenseStudio NullSenseStudio added the bug Something isn't working label Dec 28, 2022
Copy link
Owner

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@carson-katri carson-katri merged commit b525838 into main Jan 8, 2023
@NullSenseStudio NullSenseStudio deleted the iterations-fix branch January 8, 2023 19:32
@carson-katri carson-katri added this to the v0.0.10 milestone Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression - 4 images gets generated but only one image remains
2 participants