-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle fp16
branches
#479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good. There's a few issues however.
In hf_snapshot_download()
from diffusers.hub_utils import http_user_agent
needs changed to
from diffusers.utils.hub_utils import http_user_agent
due to a recent change in diffusers.
Co-authored-by: NullSenseStudio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good besides a deprecation warning I noticed.
Co-authored-by: NullSenseStudio <[email protected]>
Fixes an issue where errors would appear trying to load a model that only had a
fp16
revision downloaded. This could happen if a user previously useddiffusers
to download a model outside of the add-on.A new checkbox is also added to the "Find Models" box to prefer downloading
fp16
branches instead ofmain
if possible. This is very useful for users who only run in "Half Precision" and don't need to download the larger weights. If the model doesn't have afp16
branch, it falls back on whichever branch is default.