Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle fp16 branches #479

Merged
merged 9 commits into from
Jan 15, 2023
Merged

Properly handle fp16 branches #479

merged 9 commits into from
Jan 15, 2023

Conversation

carson-katri
Copy link
Owner

Fixes an issue where errors would appear trying to load a model that only had a fp16 revision downloaded. This could happen if a user previously used diffusers to download a model outside of the add-on.

A new checkbox is also added to the "Find Models" box to prefer downloading fp16 branches instead of main if possible. This is very useful for users who only run in "Half Precision" and don't need to download the larger weights. If the model doesn't have a fp16 branch, it falls back on whichever branch is default.

@carson-katri carson-katri added the bug Something isn't working label Dec 25, 2022
Copy link
Collaborator

@NullSenseStudio NullSenseStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good. There's a few issues however.

In hf_snapshot_download()
from diffusers.hub_utils import http_user_agent needs changed to
from diffusers.utils.hub_utils import http_user_agent due to a recent change in diffusers.

Copy link
Collaborator

@NullSenseStudio NullSenseStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good besides a deprecation warning I noticed.

@carson-katri carson-katri merged commit 279f163 into main Jan 15, 2023
@carson-katri carson-katri added this to the v0.0.10 milestone Jan 15, 2023
@carson-katri carson-katri deleted the branch-name-fix branch January 26, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants