-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Seamless Detection #410
Conversation
Looks great! Would you want to include the training script (possibly with a top level My suggestion for the interface would be to change the "Seamless" checkbox to a dropdown with the options:
where "Automatic" is the default (or maybe "Auto-detect"). What do you think? |
I plan on adding the training script but it's quite a mess right now and really should have comments explaining certain parts of it. I think naming the option "Auto-detect" would be suitable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple suggestions.
Co-authored-by: Carson Katri <[email protected]>
Co-Authored-By: Carson Katri <[email protected]>
Co-authored-by: Carson Katri <[email protected]>
Do you normally squash and merge when complete? |
Yep |
Adds automatic seamless axis detection to simplify source image and upscaling (when supported) workflows. Currently only shows the detected result, but once finished it'll have options to automatically apply the result, prompt the user to change, or have detection disabled.
Detection is done through a custom trained model on 2000 generated images with 2x and 4x Real-ESRGAN upscaled versions of each. Accuracy is 99.75% per edge or 99.5% per image and may vary somewhat depending on the type of textures that're run through it.