Render Pass Fix #370
Merged
Render Pass Fix #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carson-katri
added a commit
that referenced
this pull request
Nov 1, 2022
* Bump version to 0.0.8 * Update README * Attempt to fix macOS intel build * Disable cache: 'pip' on all jobs * Update requirements paths * Fix ZIP path for macOS intel build * Pin StabilitySDK version * Fix issue with DreamStudio as the render pass backend * Add exception handling for DreamStudio-only builds * tqdm decorator fix (#369) * Render Pass Fix (#370) * use args instead of headless_prompt * set events after completion instead of first image Co-authored-by: NullSenseStudio <[email protected]>
JasonHoku
pushed a commit
to JasonHoku/dream-textures
that referenced
this pull request
Dec 20, 2022
* Bump version to 0.0.8 * Update README * Attempt to fix macOS intel build * Disable cache: 'pip' on all jobs * Update requirements paths * Fix ZIP path for macOS intel build * Pin StabilitySDK version * Fix issue with DreamStudio as the render pass backend * Add exception handling for DreamStudio-only builds * tqdm decorator fix (carson-katri#369) * Render Pass Fix (carson-katri#370) * use args instead of headless_prompt * set events after completion instead of first image Co-authored-by: NullSenseStudio <[email protected]>
JasonHoku
pushed a commit
to JasonHoku/dream-textures
that referenced
this pull request
Dec 20, 2022
* use args instead of headless_prompt * set events after completion instead of first image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced when color correction was added, causing the render pass to use it when it shouldn't be, and other odd bugs cascading such as the frontend during OCIO inversion receiving that color corrected image while its backend crashes attempting to open an already closed shared_memory object.
These changes make sure that the render pass does not use the prompt_to_image color correction and keeps later stages from running until the previous one is entirely completed to prevent race conditions.