Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add File Batch and Re-Enable Iterations #332

Merged
merged 6 commits into from
Oct 23, 2022
Merged

Add File Batch and Re-Enable Iterations #332

merged 6 commits into from
Oct 23, 2022

Conversation

carson-katri
Copy link
Owner

This adds a new prompt preset called "File Batch", which runs the prompts from each line of a file:
Screen Shot 2022-10-18 at 2 27 00 PM

I also re-enabled the "Iterations" option, as it seems to be working fine now.

@carson-katri carson-katri linked an issue Oct 18, 2022 that may be closed by this pull request
@carson-katri carson-katri added this to the v0.0.8 milestone Oct 18, 2022
Copy link
Collaborator

@NullSenseStudio NullSenseStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great so far.

There is an issue with the history entries though. With iterations or batching it'll only store the seed from the last generated image, and with batching the prompt will just be an empty string.

Do you think it would be better to save individual entries per each image or lists for prompt and seeds in a single entry?

@carson-katri
Copy link
Owner Author

Entries are now created for each prompt, depending on batch/iterations. Also, iterations is forced to 1 when using file batch. This could potentially be lifted in the future.

@carson-katri carson-katri added the enhancement New feature or request label Oct 23, 2022
Copy link
Collaborator

@NullSenseStudio NullSenseStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more issue. The rest is working great.

Co-authored-by: NullSenseStudio <[email protected]>
@carson-katri carson-katri merged commit ca70f03 into main Oct 23, 2022
@carson-katri carson-katri deleted the batching branch October 23, 2022 22:59
JasonHoku pushed a commit to JasonHoku/dream-textures that referenced this pull request Dec 20, 2022
* Re-enable iterations

* Add prompt file batching

* Cleanup

* Revise history entries

* Force iterations to 1 when using the 'file_batch' structure is used

* Update operators/dream_texture.py

Co-authored-by: NullSenseStudio <[email protected]>

Co-authored-by: NullSenseStudio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Dream Textures Batch output?
2 participants