Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Refactor #240

Merged
merged 13 commits into from
Oct 5, 2022
Merged

UI Refactor #240

merged 13 commits into from
Oct 5, 2022

Conversation

carson-katri
Copy link
Owner

Moved each subsection into a subpanel, which matches Blender's UI better.
Screen Shot 2022-10-03 at 11 26 30 PM

@carson-katri carson-katri linked an issue Oct 4, 2022 that may be closed by this pull request
@carson-katri
Copy link
Owner Author

Model weight setup UI has been replaced with a open file dialog and automatic copying to the correct directory with shutil.

@carson-katri carson-katri linked an issue Oct 4, 2022 that may be closed by this pull request
7 tasks
@carson-katri
Copy link
Owner Author

I added a JSON-based prompt import/export, as well as some simple history management options.

Export from the history panel, then import in the Dream Texture panel.

@carson-katri
Copy link
Owner Author

carson-katri commented Oct 4, 2022

@NullSenseStudio Can I get your review on this before merging? I can't request review via GitHub UI from non-members, so if you'd like I can make you a co-maintainer on the repo.

@NullSenseStudio
Copy link
Collaborator

@carson-katri I should have some time to review soon. Thanks for the offer of being made co-maintainer but what all does that entail? This is the first repo I've done much help with and still learning things as I go.

@carson-katri
Copy link
Owner Author

@NullSenseStudio Basically it would give you some extra permissions, such as merging pull requests, give approvals, close issues, etc. you could also make branches on this repo instead of your fork for PRs. If you don’t want that level of permissions yet that’s perfectly fine with me

@NullSenseStudio
Copy link
Collaborator

@carson-katri Alright I'll accept it. I'll just stick to managing branches in my own fork and let you handle merging for now until I understand things better. Reviewing these changes now.

Copy link
Collaborator

@NullSenseStudio NullSenseStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good seeing all the clarifying information on the ui and simplified weights installation.

Only found two issues. First being that Blender thinks most of these properties are okay to animate, and I don't know what change is causing that.
image

@carson-katri
Copy link
Owner Author

That can be disabled fairly easily 👍

@NullSenseStudio
Copy link
Collaborator

Would it also be possible in the export prompt dialog to have the filename match the subject?

Copy link
Collaborator

@NullSenseStudio NullSenseStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great

@carson-katri carson-katri merged commit 752f563 into main Oct 5, 2022
@carson-katri carson-katri deleted the ui branch October 5, 2022 01:49
JasonHoku pushed a commit to JasonHoku/dream-textures that referenced this pull request Dec 20, 2022
* Fix step count

* Refactor into subpanels

* Remove Troubleshooting section

* Use file picker to copy weights instead of manual installation

* Replace Real-ESRGAN setup with ImportHelper

* Add soft_min/soft_max to simulate exclusive clamped values

* Add history management options and improved interface

* Add prompt import/export

* Fix seed export

* Update submodules to fix inpainting

* Disable property animation UI

* Re-implement readonly field, use prompt subject as default filepath

* Add UI for negative prompts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use subpanels instead of custom sections in UI Widget Limits Issue
2 participants