-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Real-ESRGAN integration #233
Conversation
Due to the stable diffusion branch change I've been getting For some reason Blender puts its So far only workarounds I've got are copying/symlink if sys.platform == 'win32':
from ctypes import WinDLL
WinDLL(r"C:\Blender\stable\blender-3.3.0+lts.0759f671ce1f\python3.dll") We should be able to get a proper path for other systems by modifying bpy.app.binary_path and sending to the subprocess as a command line argument. |
@NullSenseStudio Thanks for catching this, I hadn’t gotten to Windows testing yet. Would you be able to implement that suggestion as a PR against this branch? Also I assume the DLL is at the root for blender installations in Program Files as well? |
I should have time to do that later today. I'll also double check if the solution works for the msi installer and on steam. |
PR has been made and can confirm that zip, msi, and steam versions all had the same issue and worked with the fix. |
@NullSenseStudio Can you give this a try before I merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some issues I ran into.
FYI, I added a "Full Precision" option to the upscaler but default to enabled. The precision options for the Dream Texture panel has been overhauled as well, and use an "Automatic" option now which can autodetect 16 series cards (due to invoke-ai enhancements). |
Nice addition. Looks like everything is working well now. Did there used to be a strength option for upscaling or am I misremembering? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All previous issues seem fixed.
Thanks for the reviews! I removed strength (for now) because it required two weight files to be downloaded which could be confusing, and it also is not available in 0.2.5.0 as far as I could tell (the |
* Add Real-ESRGAN integration * Use SharedMemory to pass image data around and support outscale argument * Updates for latest submodule changes * fix cv2 ImportError (carson-katri#237) * Support Image Texture nodes * Revisions from review Co-authored-by: NullSenseStudio <[email protected]>
A new "AI Upscaling" panel has been added. I also refactored the generator process a bit to allow for multiple "Intents" (the two current ones being

PROMPT_TO_IMAGE
andUPSCALE
)