Subprocess IPC improvements #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carson-katri
approved these changes
Oct 2, 2022
JasonHoku
pushed a commit
to JasonHoku/dream-textures
that referenced
this pull request
Dec 20, 2022
* redesigned backend to frontend ipc * adding docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesigned backend to frontend IPC messages to be more easily modified and less prone to cause complicated issues like exceptions in the middle of writing an action to stdout. Added docstrings so other maintainers can better understand what a few parts do. Exception messages can now include a simplified user seen message and a stderr printed stacktrace, and has simplified integration when send_exception() is called within an except block. Message sending is also simplified by the send_action() function automatically packaging kwargs into json instead of individually writing things to stdout.
Fixes regression #192. The error check that is causing that regression has been swapped for a similar one that doesn't have expectations based on user input width and height.