fix #244

cars10 · Jul 23, 2024 · 4c68dd6 · 4c68dd6
1 parent 6d451da
commit 4c68dd6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 1.0.10
 
 * fix table column size regression introduced in `1.0.9`, fixes [#245](https://github.com/cars10/elasticvue/issues/245)
+* fix filtering when `null` values are present, fixes [#244](https://github.com/cars10/elasticvue/issues/244)
 
 ## 1.0.9
 

diff --git a/src/helpers/filters.ts b/src/helpers/filters.ts
@@ -14,14 +14,14 @@ export function filterItems<T extends Filterable> (items: T[], searchQuery: stri
     if (column.trim() === '') return items
 
     return items.filter(item => {
-      if (Object.hasOwnProperty.bind(item)(column)) {
+      if (Object.hasOwnProperty.bind(item)(column) && item[column] !== null) {
         return item[column].toString().toLowerCase().includes(query)
       }
     })
   } else {
     return items.filter(item => {
       return headerNames.some(headerName => {
-        if (Object.hasOwnProperty.bind(item)(headerName)) {
+        if (Object.hasOwnProperty.bind(item)(headerName) && item[headerName] !== null) {
           return item[headerName].toString().toLowerCase().includes(search)
         }
       })