Merge pull request #27 from software-is-art/equals-identity-short-cir…

…cuit

Added Identity Short Circuit to equals methods (Callum Galbreath)

CHANGES.txt

@@ -6,6 +6,8 @@
 
    GH-25: Added addAll(KTypeContainer) on KTypeSet. (Erich Schubert, Dawid Weiss).
 
+   GH-27: Added identity short circuit to existing equals methods. (Callum Galbreath).
+
 ** Bugs
 
 

hppc/src/main/templates/com/carrotsearch/hppc/KTypeArrayDeque.java

@@ -864,11 +864,12 @@ public int hashCode() {
 #end 
      */
   @Override
-  public boolean equals(Object obj)
-  {
-    return obj != null &&
-           getClass() == obj.getClass() &&
-           equalElements(getClass().cast(obj));
+  public boolean equals(Object obj) {
+    return (this == obj) || (
+      obj != null &&
+      getClass() == obj.getClass() &&
+      equalElements(getClass().cast(obj))
+    );
   }
 
   /**

hppc/src/main/templates/com/carrotsearch/hppc/KTypeArrayList.java

@@ -482,9 +482,11 @@ public int hashCode() {
      */
   @Override
   public boolean equals(Object obj) {
-      return obj != null &&
-             getClass() == obj.getClass() &&
-             equalElements(getClass().cast(obj));
+    return (this == obj) || (
+      obj != null &&
+      getClass() == obj.getClass() &&
+      equalElements(getClass().cast(obj))
+    );
   }
 
   /**

hppc/src/main/templates/com/carrotsearch/hppc/KTypeHashSet.java

@@ -410,9 +410,11 @@ public int hashCode() {
    */
   @Override
   public boolean equals(Object obj) {
-    return obj != null &&
-           getClass() == obj.getClass() &&
-           sameKeys(getClass().cast(obj));
+    return (this == obj) || (
+      obj != null &&
+      getClass() == obj.getClass() &&
+      sameKeys(getClass().cast(obj))
+    );
   }
 
   /**

hppc/src/main/templates/com/carrotsearch/hppc/KTypeVTypeHashMap.java

@@ -613,9 +613,11 @@ public int hashCode() {
    */
   @Override
   public boolean equals(Object obj) {
-    return obj != null &&
-           getClass() == obj.getClass() &&
-           equalElements(getClass().cast(obj));
+    return (this == obj) || (
+      obj != null &&
+      getClass() == obj.getClass() &&
+      equalElements(getClass().cast(obj))
+    );
   }
 
   /**

hppc/src/main/templates/com/carrotsearch/hppc/KTypeVTypeWormMap.java

@@ -421,6 +421,9 @@ public void release() {
   @Override
   @SuppressWarnings("unchecked")
   public boolean equals(Object o) {
+    if (this == o) {
+      return true;
+    }
     if (o == null || getClass() != o.getClass()) {
       return false;
     }

hppc/src/main/templates/com/carrotsearch/hppc/KTypeWormSet.java

@@ -351,6 +351,9 @@ public void release() {
   @Override
   @SuppressWarnings("unchecked")
   public boolean equals(Object o) {
+    if (this == o) {
+      return true;
+    }
     if (o == null || getClass() != o.getClass()) {
       return false;
     }