-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Helper Changes #7
Conversation
W.all([nodefn.call(fs.readdir, dir), nodefn.call(fs.readdir, expected)]) | ||
.spread (dir, expected) -> String(dir) == String(expected) | ||
else | ||
String(fs.readdirSync(dir)) == String(fs.readdirSync(expected)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering you're creating type String
, you should just use the ===
operator as it won't perform type conversions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coffee-script
does this automatically: http://coffeescript.org/#try:alert%20'500'%20%3D%3D%20500
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, didn't realize it interchanged ==
and ===
, been looking at javascript for too long hah
Looks good to me, you cleared up the only thought I had on the matter :) |
This is great, an excellent set of changes, well executed, and nice clean commits. On board with all the changes here as well. Gold PR star 🌟 I'll have this shipped out in a moment |
Summary of Changes
Roots.analytics
for test helpers{ async: true }
as the last parameter to every test helper method. This makes the method run asynchronously and return a promise. This however, does not apply toproject.compile
andproject.install_dependencies
, which both are now fully asynchronous by default, as opposed to a mix of sync and async logicBreaking Change
project.compile
methodroots-contentful
on TravisNon-Breaking Changes
fs.exists
methods for one that usesfs.stat
instead{ async: true }
option to helper methods to optionally make them asynchronous (they will return promises if this option is set)is_empty
tests run on CI, teardown, etc