GCS: pass acl_header for public read if fog is public

If not done, uploading a file via carrierwave with fog_public will return access denied. Closes #2426
carrierwaveuploader · Dec 30, 2020 · 92a69de · 92a69de
1 parent 3084b24
commit 92a69de
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/carrierwave/storage/fog.rb b/lib/carrierwave/storage/fog.rb
@@ -497,6 +497,8 @@ def file
         def acl_header
           if fog_provider == 'AWS'
             { 'x-amz-acl' => @uploader.fog_public ? 'public-read' : 'private' }
+          elsif fog_provider == "Google"
+            @uploader.fog_public ? { destination_predefined_acl: "publicRead" } : {}
           else
             {}
           end

diff --git a/spec/storage/fog_helper.rb b/spec/storage/fog_helper.rb
@@ -69,6 +69,9 @@ def check_file
             if @provider == 'AWS'
               expect(@storage.connection).to receive(:copy_object)
                                               .with(anything, anything, anything, anything, { "x-amz-acl"=>"public-read" }).and_call_original
+            elsif @provider == 'Google'
+              expect(@storage.connection).to receive(:copy_object)
+                                              .with(anything, anything, anything, anything, { destination_predefined_acl: "publicRead" }).and_call_original
             else
               expect(@storage.connection).to receive(:copy_object)
                                               .with(anything, anything, anything, anything, {}).and_call_original