Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed YouTube videos #682

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Conversation

maxim-belkin
Copy link
Contributor

I propose to embed Youtube videos with installation instructions (see the screenshot below).

We can limit the width of videos on large screens.
If we don't want to do that -- we won't need .yt-wrapper2 class / div.

Screenshot

image

@netlify
Copy link

netlify bot commented Jul 7, 2020

Deploy preview for zen-ride-08ffd1 ready!

Built with commit 5adaa0c

https://deploy-preview-682--zen-ride-08ffd1.netlify.app

@fmichonneau
Copy link
Contributor

Thanks Maxim. I hadn't seen your PR when I wrote this comment. Could you please update the links to use their "privacy-enhanced mode"?

@maxim-belkin
Copy link
Contributor Author

maxim-belkin commented Jul 21, 2020

Updated.
Description of settings: https://developers.google.com/youtube/player_parameters#Parameters

My question about the width of videos on large screen remains -- do we want to limit it in any way or do we want videos to use the full width of the body?

@maxim-belkin
Copy link
Contributor Author

Rebased

@fmichonneau
Copy link
Contributor

the current width settings look good to me. I'm happy for this to be merged as is. Thanks!

@maxim-belkin maxim-belkin marked this pull request as ready for review July 27, 2020 07:40
@maxim-belkin
Copy link
Contributor Author

maxim-belkin commented Jul 27, 2020

the current width settings look good to me. I'm happy for this to be merged as is. Thanks!

Marked the PR as ready. I left the yt-wrapper2 class in place in case we decide to limit width of videos in the future.
Thank you, François!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants