Adding Caution Callout #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linked to the Sandpaper PR: carpentries/sandpaper#613 Thanks @MttArmstrong ! |
|
Although the contrast in light mode for the icon could be improved: |
I have updated the color to be white in both lite/dark modes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When translating old modules, I noticed that the "Caution" callout is excluded in the new varnish/sandpaper packages.
If this was unintentional, I have prepared this PR to re-add this callout to Varnish, and will be submitting a similar PR to sandpaper as well.
This issue was also reported in the sandpaper-docs repo (carpentries/sandpaper-docs#179)