Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: don't fail when Python isn't found #566

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Makefile: don't fail when Python isn't found #566

merged 1 commit into from
Mar 24, 2021

Conversation

maxim-belkin
Copy link
Contributor

Python shouldn't be a hard requirement in our Makefile -- there are targets that don't need Python at all (serve, site, clean, docker-serve, etc.) Instead, make it a hard requirement for targets that need it.

@zkamvar zkamvar self-requested a review March 23, 2021 15:06
zkamvar
zkamvar approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@zkamvar zkamvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! This is a major pain point for a lot of folks and removing this barrier would make the process a lot easier

@maxim-belkin
Copy link
Contributor Author

Thanks, Zhian!

@maxim-belkin maxim-belkin merged commit 50fd61f into carpentries:gh-pages Mar 24, 2021
@maxim-belkin maxim-belkin deleted the python-note branch March 24, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkamvar zkamvar zkamvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxim-belkin @zkamvar