Makefile: use SHELL to call bin/knit_lesson.sh #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-belkin
force-pushed
the
call-sh-knit
branch
from
8e5d4c9 to
acc9fa4
Compare
zkamvar
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
This looks okay to me. I know that our scripts assume BASH, but modern macOS uses zsh, so I tried checking the scripts with shellcheck --shell shand the only one that doesn't pass the test is bin/run-make-docker-serve.sh, which we no longer use (and should be removed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
SHELLto callbin/knit_lessons.shscript. This should let us avoid relying on the executable bit of the script.