Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: better cleanup #560

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Makefile: better cleanup #560

merged 1 commit into from
Mar 18, 2021

Conversation

maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented Mar 18, 2021 •
edited
Loading

Clean up:

  1. .vendor directory where Bundler installed all the gems.
  2. .bundle directory where Bundler stored its settings.
  3. Gemfile.lock file generated by Bundler.

@maxim-belkin
Makefile: better cleanup
1061893 
Clean up:

1. `.vendor` directory where Bundler installed all the gems.
2. `.bundle` directory where Bundler stored its settings.
3. `Gemfile.lock` file generated by Bundler.
@zkamvar zkamvar self-requested a review March 18, 2021 17:21
zkamvar
zkamvar approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@zkamvar zkamvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxim-belkin
Copy link
Contributor Author

Thanks, @zkamvar!

@maxim-belkin maxim-belkin merged commit b43257a into carpentries:gh-pages Mar 18, 2021
@maxim-belkin maxim-belkin deleted the more-cleanup branch March 18, 2021 22:13
@maxim-belkin maxim-belkin mentioned this pull request Mar 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkamvar zkamvar zkamvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxim-belkin @zkamvar