Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update LICENSE and COC links #458

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

update LICENSE and COC links #458

wants to merge 1 commit into from

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Mar 18, 2020

Since the user is always directed here, the links should point to the correct pages. The COC link is a bit bare, however since the relevant content is Jekyll-derived. Maybe we should just link the Carpentries code of conduct instead?

@maneesha
Copy link
Contributor

This came up in another context before, where GitHub automatically links to a project's COC file. I agree that this should link to our CoC.

@maxim-belkin
Copy link
Contributor

Thank you for the PR, Zhian.
Thank you for your comment, Maneesha.

When maintainers synchronize lessons with carpentries/styles repository, they copy files from bin/boilerplate directory to the corresponding lessons' directories. So, bin/boilerplate/CONTRIBUTING.md is copied to the root folder replacing the current CONTRIBUTING.md file. The change suggested in this PR would, therefore, brake the link.

We can link to https://docs.carpentries.org/topic_folders/policies/index_coc.html, however, I feel that we should discuss this change before implementing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants