Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "you are here" figures #453

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Update "you are here" figures #453

merged 2 commits into from
Nov 29, 2024

Conversation

tobyhodges
Copy link
Member

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Closes #411

Copy link

github-actions bot commented Nov 29, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/lesson-development-training/compare/md-outputs..md-outputs-PR-453

The following changes were observed in the rendered markdown documents:

 fig/cldt-design-process.svg | 663 +++++++++++++++++++++++++++++++-
 fig/cldt-step-1.svg         | 909 ++++++++++++++++++++++++++++++-------------
 fig/cldt-step-2.svg         | 914 ++++++++++++++++++++++++++++++-------------
 fig/cldt-step-3.svg         | 917 +++++++++++++++++++++++++++++++-------------
 fig/cldt-step-4.svg         | 910 ++++++++++++++++++++++++++++++-------------
 fig/cldt-step-5.svg         | 917 +++++++++++++++++++++++++++++++-------------
 6 files changed, 3894 insertions(+), 1336 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-11-29 10:48:51 +0000

github-actions bot pushed a commit that referenced this pull request Nov 29, 2024
Copy link
Collaborator

@anenadic anenadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I always find tediting SVGs a bit problematic - fonts missing, text being converted to uneditable objects, etc.

github-actions bot pushed a commit that referenced this pull request Nov 29, 2024
@tobyhodges tobyhodges merged commit 04f4b38 into main Nov 29, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 29, 2024
Auto-generated via `{sandpaper}`
Source  : 04f4b38
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-11-29 10:49:43 +0000
Message : Merge pull request #453 from carpentries/update-design-step-figs

Update "you are here" figures
github-actions bot pushed a commit that referenced this pull request Nov 29, 2024
Auto-generated via `{sandpaper}`
Source  : 3b1acd9
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-29 10:50:21 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 04f4b38
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-11-29 10:49:43 +0000
Message : Merge pull request #453 from carpentries/update-design-step-figs

Update "you are here" figures
@anenadic anenadic deleted the update-design-step-figs branch December 4, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "you are here" figures at beginning of episodes
2 participants