Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves around fenced div introduction and exercises #441

Merged
merged 11 commits into from
Nov 28, 2024
Merged

Conversation

anenadic
Copy link
Collaborator

@anenadic anenadic commented Nov 4, 2024

Fixes #415.

@anenadic anenadic requested a review from tobyhodges November 4, 2024 14:04
Copy link

github-actions bot commented Nov 4, 2024

❌ DANGER ❌

This pull request has modified workflows that created output. Close this now.

github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anenadic, especially for the annotated screenshots, which are a huge improvement. I have suggested a few language polishes, and asked a question about how we want to frame discussions as different from challenges

episodes/lesson-content.md Outdated Show resolved Hide resolved
episodes/lesson-content.md Outdated Show resolved Hide resolved
episodes/lesson-content.md Outdated Show resolved Hide resolved
episodes/lesson-content.md Outdated Show resolved Hide resolved
episodes/lesson-content.md Outdated Show resolved Hide resolved
episodes/lesson-content.md Outdated Show resolved Hide resolved
episodes/lesson-content.md Outdated Show resolved Hide resolved
episodes/lesson-content.md Outdated Show resolved Hide resolved
episodes/lesson-content.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
@anenadic anenadic requested a review from tobyhodges November 28, 2024 15:40
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anenadic 🙌

@tobyhodges tobyhodges merged commit 124a5d9 into main Nov 28, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
Auto-generated via `{sandpaper}`
Source  : 124a5d9
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-11-28 15:54:01 +0000
Message : Merge pull request #441 from carpentries/issue-415

Moves around fenced div introduction and exercises
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
Auto-generated via `{sandpaper}`
Source  : ebdb113
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-28 15:54:50 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 124a5d9
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-11-28 15:54:01 +0000
Message : Merge pull request #441 from carpentries/issue-415

Moves around fenced div introduction and exercises
@anenadic
Copy link
Collaborator Author

Still fixing this :-) @tobyhodges - need to add a note on solutions for discussions

@anenadic
Copy link
Collaborator Author

Oh, you have done it already - many thanks @tobyhodges 🎉 .

@anenadic anenadic deleted the issue-415 branch December 4, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move fenced divs to a separate subsection in adding lesson content episode
2 participants