Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update infrastructure.md #370

Merged
merged 2 commits into from
May 22, 2024

Conversation

thisHermit
Copy link
Contributor

Resolves #309 by changing links for templates to point to the repos instead and adding instruction to inform learners to click on "Use the template" button.

change links and add point to instruct learners to click on "Use the template" button as suggested in carpentries#309
Copy link

github-actions bot commented May 22, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/lesson-development-training/compare/md-outputs..md-outputs-PR-370

The following changes were observed in the rendered markdown documents:

 infrastructure.md | 5 +++--
 md5sum.txt        | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-22 07:45:13 +0000

Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for contributing, @thisHermit. It looks great to me.

Before I merge, please could you add your details to the list of authors in CITATION.cff? Authors are listed alphabetically by last name.

github-actions bot pushed a commit that referenced this pull request May 22, 2024
Add name to list of authors
@tobyhodges
Copy link
Member

Thanks again 🙌 Time permitting, I hope you'll consider making additional contributions in the future.

github-actions bot pushed a commit that referenced this pull request May 22, 2024
@tobyhodges tobyhodges merged commit e563d48 into carpentries:main May 22, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 22, 2024
Auto-generated via {sandpaper}
Source  : e563d48
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-05-22 07:46:27 +0000
Message : Merge pull request #370 from thisHermit/309-template-repository-flow

Link to template repositories instead of directly to repo creation forms
github-actions bot pushed a commit that referenced this pull request May 22, 2024
Auto-generated via {sandpaper}
Source  : a6c6251
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-22 07:47:27 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e563d48
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-05-22 07:46:27 +0000
Message : Merge pull request #370 from thisHermit/309-template-repository-flow

Link to template repositories instead of directly to repo creation forms
github-actions bot pushed a commit that referenced this pull request May 28, 2024
Auto-generated via {sandpaper}
Source  : a6c6251
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-22 07:47:27 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e563d48
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-05-22 07:46:27 +0000
Message : Merge pull request #370 from thisHermit/309-template-repository-flow

Link to template repositories instead of directly to repo creation forms
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : a6c6251
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-22 07:47:27 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e563d48
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-05-22 07:46:27 +0000
Message : Merge pull request #370 from thisHermit/309-template-repository-flow

Link to template repositories instead of directly to repo creation forms
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Auto-generated via {sandpaper}
Source  : a6c6251
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-22 07:47:27 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e563d48
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-05-22 07:46:27 +0000
Message : Merge pull request #370 from thisHermit/309-template-repository-flow

Link to template repositories instead of directly to repo creation forms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to Markdown and RMarkdown templates should point to respective repos
2 participants