Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'shiny' (English) definition #308

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Added 'shiny' (English) definition #308

merged 2 commits into from
Sep 10, 2021

Conversation

Charlie-George
Copy link
Contributor

Fill in each of the sections (using NA for those that are not applicable).

Author:

  • Charlotte George

Language:

  • English

Terms defined:

  • Shiny

@Charlie-George Charlie-George mentioned this pull request Apr 16, 2021
Open
12 tasks
annajiat
annajiat reviewed Sep 10, 2021
View reviewed changes
Copy link
Contributor

@annajiat annajiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
May wish to check for spelling and style,
specially adding reference to javascript

customizations in shiny dashboard may utilize css, javascript.
Hence the last clause may be omitted that html/css/js is not required.

fmichonneau
fmichonneau reviewed Sep 10, 2021
View reviewed changes
glossary.yml Outdated Show resolved Hide resolved
@fmichonneau fmichonneau added the lang: en issues and PR for English entries label Sep 10, 2021
@fmichonneau fmichonneau requested a review from a team September 10, 2021 14:33
@annajiat @fmichonneau
Update glossary.yml
4afd7dc 
Co-authored-by: François Michonneau <[email protected]>
@annajiat annajiat merged commit 659bf08 into carpentries:master Sep 10, 2021
@Charlie-George Charlie-George deleted the cg-shiny-deffinition branch September 14, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmichonneau fmichonneau fmichonneau left review comments

@annajiat annajiat annajiat approved these changes

Assignees
No one assigned
Labels
lang: en issues and PR for English entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Charlie-George @annajiat @fmichonneau