Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Poetry #2756

Merged
merged 28 commits into from
Feb 16, 2025
Merged

Switch to Poetry #2756

merged 28 commits into from
Feb 16, 2025

Conversation

pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Feb 8, 2025

This fixes #2737.

@pbanaszkiewicz pbanaszkiewicz added component: deployment dependencies Pull requests that update a dependency file labels Feb 8, 2025
@pbanaszkiewicz pbanaszkiewicz added this to the v4.7 milestone Feb 8, 2025
@pbanaszkiewicz pbanaszkiewicz self-assigned this Feb 8, 2025
@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2737-switch-to-poetry branch 3 times, most recently from d7c5d76 to 50fcfdc Compare February 12, 2025 20:58
@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2737-switch-to-poetry branch from 4f8496a to df08a96 Compare February 14, 2025 15:42
There's a pending error in that library, similar to typeddjango/django-stubs#2479.

Unfortunately the upgrade didn't help, developers may have to use `--no-verify` when committing.
This indicates what is required in `manage.py test` command to run correctly.

The path is required because `amy/` directory is not a package (doesn't contain `__init__.py` file), which isn't supported by unittest discovery:
https://docs.python.org/3/library/unittest.html#test-discovery (see note at the end of the linked section).
Unified to 1 function for handling next or default URL, 1 function for confirming if URL is safe. Added tests and improved some typing.
@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2737-switch-to-poetry branch from 25181f4 to 494f503 Compare February 16, 2025 07:32
@pbanaszkiewicz pbanaszkiewicz marked this pull request as ready for review February 16, 2025 11:02
@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2737-switch-to-poetry branch from 70f0da7 to 010e70d Compare February 16, 2025 11:15
@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2737-switch-to-poetry branch from 010e70d to 0ca4ff3 Compare February 16, 2025 11:29
@pbanaszkiewicz pbanaszkiewicz merged commit c8a8504 into develop Feb 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: deployment dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to poetry
1 participant