Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emails] New membership onboarding email #2580

Merged
merged 14 commits into from
Dec 16, 2023
Merged

[Emails] New membership onboarding email #2580

merged 14 commits into from
Dec 16, 2023

Conversation

pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Nov 26, 2023 •
edited
Loading

This fixes #2577.

@pbanaszkiewicz pbanaszkiewicz added this to the v4.3 milestone Nov 26, 2023
@pbanaszkiewicz
Copy link
Contributor Author

pbanaszkiewicz commented Nov 28, 2023 •
edited
Loading

@elichad This is quite close to completion, you may take a look.

I'm still not quite happy about some of the solutions here.

  1. When I removed all contacts from the membership, I expected the scheduled email to be cancelled. It wasn't and I will be looking into this case.
  2. I'm using a "hack" to determine if membership can or can't be deleted. If it can be removed, then I'm running the strategy to remove related emails. This was required because if the membership had been removed (before strategy is run), then running the strategy would fail. I'll look into other approach here.

@pbanaszkiewicz
[#2577] Email template for New Membership - Onboarding
937bfff
@pbanaszkiewicz
[#2577] Add New Membership Onboarding strategy and receivers - initial
90472c4
@pbanaszkiewicz
[#2577] Fix tests
42369a6
@pbanaszkiewicz
[#2577] Extend new membership strategy to membership tasks view
6dcc782
@pbanaszkiewicz
[#2577] Add tests for email action's common functions
a1246f5
@pbanaszkiewicz
[#2577] Add tests for the strategy
a4b6f37
@pbanaszkiewicz
[#2577] Don't call the strategy when a person contact is required for…
7770f18 
… the email action

Instead of calling the strategy when membership is created, it is called when
person is assigned to the membership.
@pbanaszkiewicz
[#2577] Add integration tests for the email
d568e0d
@pbanaszkiewicz
[#2577] Reduce number of log entries in the test output
adc0bb4 
They were caused by logger from rq module. It's being captured from now
on.
@pbanaszkiewicz
[#2577] Handle deletable and non-deletable formsets differently
9f7f182 
Non-deletable formsets were causing unhandled errors during tests,
which led to resetting of silenced loggers.
@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2577-new-membership-email branch from 8426d2a to b9c8f5b Compare November 29, 2023 21:47
@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2577-new-membership-email branch from b9c8f5b to bf5644c Compare November 29, 2023 21:49
@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2577-new-membership-email branch from 40e16a1 to b02d515 Compare December 16, 2023 16:03
@pbanaszkiewicz pbanaszkiewicz marked this pull request as ready for review December 16, 2023 16:05
@pbanaszkiewicz
Copy link
Contributor Author

No longer WIP.

Issues from previous comment were addressed:

  1. When I removed all contacts from the membership, I expected the scheduled email to be cancelled. It wasn't and I will be looking into this case.
  2. I'm using a "hack" to determine if membership can or can't be deleted. If it can be removed, then I'm running the strategy to remove related emails. This was required because if the membership had been removed (before strategy is run), then running the strategy would fail. I'll look into other approach here.

Ad 1: membership tasks "billing contact" or "programmatic contact" are now required for the email to be created. Once there are no such contacts, the email will be cancelled.

Ad 2: The "hack" is still in place. Unfortunately I don't see any better solution there.

@pbanaszkiewicz pbanaszkiewicz self-assigned this Dec 16, 2023
@pbanaszkiewicz pbanaszkiewicz merged commit d3dc6a4 into develop Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pbanaszkiewicz pbanaszkiewicz

Labels
component: email automation component: forms
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

[Emails] Implement "New / renewing membership starting (member onboarding)" email
1 participant
@pbanaszkiewicz