Update instructor eligibility requirements with Get Involved step #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elichad
commented
Jun 23, 2023
| "not possible to add training progress", form.non_field_errors()[0] | ||
| ) | ||
|
|
||
| def test_form_with_failed_status_requires_notes(self): |
There was a problem hiding this comment.
Because this removal confused me when I looked back at the diff:
Despite the name, the content of this test is a duplicate of test_form_invalid_if_trainee_has_no_training_task, and the intent is covered by test_progress_with_failed_status_requires_notes elsewhere in this file.
froggleston
approved these changes
Jun 26, 2023
pbanaszkiewicz
approved these changes
Jun 26, 2023
elichad
changed the base branch from
2408-create-get-involved-requirement
to
feature/instructor-checkout-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of time, I'm raising this not against
feature/instructor-checkout-changesbut instead against the branch used in #2431 for review. Will not merge until #2431 is merged.Fixes #2440.
This PR will:
test_eligible_but_not_awardedtest inamy/dashboard/tests/test_instructor_dashboard.pywhich was broken by Create "Get Involved" requirement and associated Involvement model #2431test_lesson_contribution_passedinamy/dashboard/tests/test_instructor_dashboard.pywhich will be fixed as part of Add feature for trainees to self-submit "Get Involved" step #2411