Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2067] Upcoming Teaching Opportunities on instructor page #2127

Merged
merged 10 commits into from
Feb 16, 2022
Merged

[#2067] Upcoming Teaching Opportunities on instructor page #2127

merged 10 commits into from
Feb 16, 2022

Conversation

pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Feb 6, 2022 •
edited
Loading

Missing:

  • view tests
  • use Community Roles project to test user for instructor role

This fixes #2067.

@pbanaszkiewicz
[carpentries#2067] Rename trainee-dashboard -> instructor-dashboard
076e63c 
Old link will redirect to new one.
@pbanaszkiewicz
[carpentries#2067] Upcoming Teaching Opportunities list
af61ed9 
Working filters, sort-of working sorting.
TODO: proximity sorting.
@pbanaszkiewicz pbanaszkiewicz added this to the v3.5 milestone Feb 6, 2022
@pbanaszkiewicz pbanaszkiewicz self-assigned this Feb 6, 2022
@pbanaszkiewicz pbanaszkiewicz marked this pull request as draft February 7, 2022 10:38
@pbanaszkiewicz pbanaszkiewicz marked this pull request as ready for review February 9, 2022 21:14
@pbanaszkiewicz
Copy link
Contributor Author

@maneesha this is renaming dashboard URL for instructors from /dashboard/trainee to /dashboard/instructor. The old URL is redirecting to the new one. I hope this change is okay with you.

@pbanaszkiewicz pbanaszkiewicz merged commit 39674a5 into carpentries:develop Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauryndbrown lauryndbrown Awaiting requested review from lauryndbrown

@fmichonneau fmichonneau Awaiting requested review from fmichonneau

@maneesha maneesha Awaiting requested review from maneesha

Assignees

@pbanaszkiewicz pbanaszkiewicz

Labels
component: user interface (UI)
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

Instructor Selection: view Upcoming Teaching Opportunities on instructor page
1 participant
@pbanaszkiewicz