Run Slurm in the CI #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
joelnitta
reviewed
Dec 13, 2024
| @@ -1 +1 @@ | |||
| 0.16.5 | |||
| 0.14.1 | |||
There was a problem hiding this comment.
Can we keep the newer version of {sandpaper}?
If anything I think we should upgrade to latest (v 0.16.10)
joelnitta
reviewed
Dec 13, 2024
.github/workflows/README.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| This directory contains workflows to be used for Lessons using the {sandpaper} | |||
| lesson infrastructure. Two of these workflows require R (`sandpaper-main.yaml` | |||
| and `pr-receive.yaml`) and the rest are bots to handle pull request management. | |||
| and `pr-recieve.yaml`) and the rest are bots to handle pull request management. | |||
There was a problem hiding this comment.
Not sure where these changes receive -> recieve are coming from? The later is the correct spelling, and used in sandpaper
.github/workflows/README.md
Outdated
| @@ -94,7 +94,7 @@ branch called `update/workflows` and a pull request is created. Maintainers are | |||
| encouraged to review the changes and accept the pull request if the outputs | |||
| are okay. | |||
|
|
|||
| This update is run weekly or on demand. | |||
| This update is run ~~weekly or~~ on demand. | |||
There was a problem hiding this comment.
Is this part of an intentional change to prevent the modified workflow file from being overwritten by the default {sandpaper} workflow?
|
I have no idea where those changes are from either. I'll filter them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annoyingly, the sandpaper checks now prevent simultaneous workflow and lesson changes. See https://github.com/carpentries-incubator/targets-workshop/actions/runs/12309175599. Therefore I've pulled out the workflow changes to this PR.